-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix protoInit
call injection timing
#16235
Merged
JLHwung
merged 2 commits into
babel:main
from
JLHwung:fix-proto-init-call-injection-timing
Jan 26, 2024
Merged
Fix protoInit
call injection timing
#16235
JLHwung
merged 2 commits into
babel:main
from
JLHwung:fix-proto-init-call-injection-timing
Jan 26, 2024
+402
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Decorators
labels
Jan 25, 2024
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56192/ |
Previously they are injected at the first _decorated_ field, which is probably an oversight.
JLHwung
force-pushed
the
fix-proto-init-call-injection-timing
branch
from
January 25, 2024 17:50
eb49b20
to
846153c
Compare
JLHwung
commented
Jan 25, 2024
"after," + | ||
"ctor:start," + | ||
"m3,m4,m5,m6,g3,g4,g5,g6,s3,s4,s5,s6," + // instanceExtraInitializers | ||
"f," + // InitializeFieldOrAccessor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current main branch, f
is printed before m3,m4,m5,m6,g3,g4,g5,g6,s3,s4,s5,s6
.
nicolo-ribaudo
approved these changes
Jan 26, 2024
liuxingbaoyu
approved these changes
Jan 26, 2024
liuxingbaoyu
pushed a commit
to liuxingbaoyu/babel
that referenced
this pull request
Mar 5, 2024
1 task
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Jun 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Decorators
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.addInitializers
after undecorated field initializer (REPL), fixes #16188This PR includes commits from #16234, I will rebase once that PR gets merged.Per spec: InitializeInstanceElements
The method initializers should run before any fields are defined.
In the REPL example,
When the property
p
is defined, theinitCalled
should betrue
. Previously we inject theprotoInit
calls in the first decorated field, in this PR we move the field initializer injection out of thehasDecorators
branch.